Skip to content

Expose DOM element ReactComponents #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2019
Merged

Expose DOM element ReactComponents #110

merged 2 commits into from
Oct 21, 2019

Conversation

maddie927
Copy link
Member

@maddie927 maddie927 commented Oct 14, 2019 •
edited
Loading

This PR exposes the ReactComponent definitions which were previously implicit in the DOM module.

Fixes #109
Fixes #106

@maddie927 maddie927 self-assigned this Oct 14, 2019
@maddie927 maddie927 force-pushed the madeline/expose-dom-react-components branch from 8f49017 to 19797a1 Compare October 14, 2019 17:28
jongleb
jongleb reviewed Oct 18, 2019
View reviewed changes
Copy link

@jongleb jongleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why div' className is required?

@maddie927
Copy link
Member Author

It shouldn't be. What do you mean?

@maddie927 maddie927 merged commit df35836 into master Oct 21, 2019
@maddie927 maddie927 deleted the madeline/expose-dom-react-components branch October 21, 2019 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jongleb jongleb jongleb left review comments

Assignees

@maddie927 maddie927

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow key prop on SVG data attributes missing from some elements
2 participants
@maddie927 @jongleb